Hello Erin Lo,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/47347
to review the following change.
Change subject: soc/mediatek/mt8192: Init SSPM ......................................................................
soc/mediatek/mt8192: Init SSPM
Load SSPM firmware and boot up SSPM.
Signed-off-by: Erin Lo erin.lo@mediatek.com Change-Id: I051478e8bac9f48b9639ee55157ec539fe89f67c --- M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8192/soc.c 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/47347/1
diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc index 22674ca..1ba67a6 100755 --- a/src/soc/mediatek/mt8192/Makefile.inc +++ b/src/soc/mediatek/mt8192/Makefile.inc @@ -75,6 +75,11 @@ spm_firmware.bin-type := raw spm_firmware.bin-compression := $(CBFS_COMPRESS_FLAG)
+cbfs-files-y += sspm.bin +sspm.bin-file := $(MT8192_BLOB_DIR)/sspm.bin +sspm.bin-type := raw +sspm.bin-compression := $(CBFS_COMPRESS_FLAG) + cbfs-files-y += mcupm.bin mcupm.bin-file := $(MT8192_BLOB_DIR)/mcupm.bin mcupm.bin-type := raw diff --git a/src/soc/mediatek/mt8192/soc.c b/src/soc/mediatek/mt8192/soc.c index 5a2fa37..883f4dc 100644 --- a/src/soc/mediatek/mt8192/soc.c +++ b/src/soc/mediatek/mt8192/soc.c @@ -5,6 +5,7 @@ #include <soc/emi.h> #include <soc/mcupm.h> #include <soc/mmu_operations.h> +#include <soc/sspm.h> #include <soc/ufs.h> #include <symbols.h>
@@ -18,6 +19,7 @@ mtk_mmu_disable_l2c_sram(); dapc_init(); mcupm_init(); + sspm_init(); ufs_disable_refclk(); }
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Erin Lo,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47347
to look at the new patch set (#6).
Change subject: soc/mediatek/mt8192: Init SSPM ......................................................................
soc/mediatek/mt8192: Init SSPM
Load SSPM firmware and boot up SSPM.
Signed-off-by: Erin Lo erin.lo@mediatek.com Change-Id: I051478e8bac9f48b9639ee55157ec539fe89f67c --- M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8192/soc.c 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/47347/6
Yidi Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47347 )
Change subject: soc/mediatek/mt8192: Init SSPM ......................................................................
Abandoned
replaced with CB:47786