Change in coreboot[master]: nb/i945/gma: Read vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34331 )
Change subject: nb/i945/gma: Read vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT ......................................................................
nb/i945/gma: Read vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT
Here, vga_disable stored but we read it only if MAINBOARD_DO_NATIVE_VGA_INIT.
Change-Id: I5c359df71568b56f48eca9615c6265da33d4a073 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/gma.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34331/1
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 54ff47c..d08b77d 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -703,9 +703,8 @@ pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER | PCI_COMMAND_IO | PCI_COMMAND_MEMORY);
- int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1; - if (CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT)) { + int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1; if (acpi_is_wakeup_s3()) { printk(BIOS_INFO, "Skipping native VGA initialization when resuming from ACPI S3.\n");
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34331
to look at the new patch set (#2).
Change subject: nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT ......................................................................
nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT
Here, vga_disable stored but we read it only if MAINBOARD_DO_NATIVE_VGA_INIT.
Change-Id: I5c359df71568b56f48eca9615c6265da33d4a073 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/gma.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34331/2
Hello Patrick Rudolph, Jacob Garber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34331
to look at the new patch set (#3).
Change subject: nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT ......................................................................
nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT
Here, vga_disable stored but we read it only if MAINBOARD_DO_NATIVE_VGA_INIT.
Found-by: scan-build 7.0.1-8 Change-Id: I5c359df71568b56f48eca9615c6265da33d4a073 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/gma.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/34331/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34331 )
Change subject: nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34331 )
Change subject: nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT ......................................................................
nb/i945/gma: Store vga_disable if MAINBOARD_DO_NATIVE_VGA_INIT
Here, vga_disable stored but we read it only if MAINBOARD_DO_NATIVE_VGA_INIT.
Found-by: scan-build 7.0.1-8 Change-Id: I5c359df71568b56f48eca9615c6265da33d4a073 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34331 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/i945/gma.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 54ff47c..d08b77d 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -703,9 +703,8 @@ pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER | PCI_COMMAND_IO | PCI_COMMAND_MEMORY);
- int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1; - if (CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT)) { + int vga_disable = (pci_read_config16(dev, GGC) & 2) >> 1; if (acpi_is_wakeup_s3()) { printk(BIOS_INFO, "Skipping native VGA initialization when resuming from ACPI S3.\n");
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)