Attention is currently required from: Jason Glenesk, ritul guru, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73372 )
Change subject: soc/amd/phoenix: Update phoenix2 VGA BIOS ID
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/73372/comment/3838efed_9f288089
PS1, Line 247: 1002,15c8
shouldn't this be 1002,1205 to match the pci id in the vbios so that both 1205 and 15c8 cases work as expected?
this is at least how it was done on cezanne and i checked there that it was correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie035baf7a0908e1e6382c1810926647bf7182f6c
Gerrit-Change-Number: 73372
Gerrit-PatchSet: 1
Gerrit-Owner: ritul guru
ritul.bits@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 02 Mar 2023 21:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment