Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58171 )
Change subject: mb/siemens/mc_ehl: Add variant_mainboard_final() ......................................................................
mb/siemens/mc_ehl: Add variant_mainboard_final()
In upcoming patches, we need mainboard specific adjustments.
Change-Id: Icf9d829b19b2d26a39ad34be4658064083e9da6d Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/58171 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/mainboard/siemens/mc_ehl/mainboard.c M src/mainboard/siemens/mc_ehl/variants/baseboard/include/baseboard/variants.h 2 files changed, 11 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_ehl/mainboard.c b/src/mainboard/siemens/mc_ehl/mainboard.c index d347567..e64dbda 100644 --- a/src/mainboard/siemens/mc_ehl/mainboard.c +++ b/src/mainboard/siemens/mc_ehl/mainboard.c @@ -127,6 +127,9 @@ { struct device *dev;
+ /* Do board specific things */ + variant_mainboard_final(); + if (CONFIG(PCI_ALLOW_BUS_MASTER_ANY_DEVICE)) { /* Set Master Enable for on-board PCI devices if allowed. */ dev = dev_find_device(PCI_VENDOR_ID_SIEMENS, 0x403e, 0); @@ -139,6 +142,11 @@ } }
+/* The following function performs board specific things. */ +void __weak variant_mainboard_final(void) +{ +} + struct chip_operations mainboard_ops = { .init = mainboard_init, .final = mainboard_final diff --git a/src/mainboard/siemens/mc_ehl/variants/baseboard/include/baseboard/variants.h b/src/mainboard/siemens/mc_ehl/variants/baseboard/include/baseboard/variants.h index bf05765..0893d99 100644 --- a/src/mainboard/siemens/mc_ehl/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/siemens/mc_ehl/variants/baseboard/include/baseboard/variants.h @@ -15,4 +15,7 @@ /* This function returns SPD related FSP-M mainboard configs */ const struct mb_cfg *variant_memcfg_config(void);
+/* The following function performs board specific things. */ +void variant_mainboard_final(void); + #endif /*__BASEBOARD_VARIANTS_H__ */