Change in coreboot[master]: amdfwtool: Move the MP2CFG checking to category of BIOS data

[Bao Zheng (Code Review)]

Hello Zheng Bao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/47587

to review the following change.

Change subject: amdfwtool: Move the MP2CFG checking to category of BIOS data
......................................................................

amdfwtool: Move the MP2CFG checking to category of BIOS data

Change-Id: Iaaf9c96dd0ed8c31bb50350d37646ca08a1bbff0
Signed-off-by: Zheng Bao 
---
M util/amdfwtool/data_parse.c
1 file changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/47587/1

diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c
index b3470d5..c2ce32b 100644
--- a/util/amdfwtool/data_parse.c
+++ b/util/amdfwtool/data_parse.c
@@ -187,13 +187,6 @@
    	} else {
    		fw_type = AMD_FW_SKIP;
    	}
-	} else if (strcmp(fw_name, "PSP_MP2CFG_FILE") == 0) {
-		if (cb_config->load_mp2_fw == 1) {
-			fw_type = AMD_BIOS_MP2_CFG;
-			subprog = 0;
-		} else {
-			fw_type = AMD_FW_SKIP;
-		}
    } else if (strcmp(fw_name, "PSP_DRIVERS_FILE") == 0) {
    	fw_type = AMD_DRIVER_ENTRIES;
    	subprog = 0;
@@ -267,6 +260,13 @@
    	fw_type = AMD_BIOS_PMUD;
    	subprog = 1;
    	instance = 4;
+	} else if (strcmp(fw_name, "PSP_MP2CFG_FILE") == 0) {
+		if (cb_config->load_mp2_fw == 1) {
+			fw_type = AMD_BIOS_MP2_CFG;
+			subprog = 0;
+		} else {
+			fw_type = AMD_FW_SKIP;
+		}
    } else {
    	fw_type = AMD_BIOS_INVALID;
    }

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47587 )

Change subject: amdfwtool: Move the MP2CFG checking to category of BIOS data
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47587 )

Change subject: amdfwtool: Move the MP2CFG checking to category of BIOS data
......................................................................

amdfwtool: Move the MP2CFG checking to category of BIOS data

Change-Id: Iaaf9c96dd0ed8c31bb50350d37646ca08a1bbff0
Signed-off-by: Zheng Bao 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47587
Tested-by: build bot (Jenkins) 
Reviewed-by: Marshall Dawson 
---
M util/amdfwtool/data_parse.c
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marshall Dawson: Looks good to me, approved

diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c
index b3470d5..c2ce32b 100644
--- a/util/amdfwtool/data_parse.c
+++ b/util/amdfwtool/data_parse.c
@@ -187,13 +187,6 @@
    	} else {
    		fw_type = AMD_FW_SKIP;
    	}
-	} else if (strcmp(fw_name, "PSP_MP2CFG_FILE") == 0) {
-		if (cb_config->load_mp2_fw == 1) {
-			fw_type = AMD_BIOS_MP2_CFG;
-			subprog = 0;
-		} else {
-			fw_type = AMD_FW_SKIP;
-		}
    } else if (strcmp(fw_name, "PSP_DRIVERS_FILE") == 0) {
    	fw_type = AMD_DRIVER_ENTRIES;
    	subprog = 0;
@@ -267,6 +260,13 @@
    	fw_type = AMD_BIOS_PMUD;
    	subprog = 1;
    	instance = 4;
+	} else if (strcmp(fw_name, "PSP_MP2CFG_FILE") == 0) {
+		if (cb_config->load_mp2_fw == 1) {
+			fw_type = AMD_BIOS_MP2_CFG;
+			subprog = 0;
+		} else {
+			fw_type = AMD_FW_SKIP;
+		}
    } else {
    	fw_type = AMD_BIOS_INVALID;
    }