Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Poornima Tom, Subrata Banik, V Sowmya.
Poornima Tom has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83076?usp=email )
Change subject: mb/google/nissa/var/nivviks: Enable Bluetooth for PCIE ......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brya/variants/nivviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83076/comment/10e949e0_b49f5e4f?usp... : PS8, Line 665: probe WIFI_CATEGORY WIFI_7
oh Interesting wat to write the device under chip. Is that working? Could you check the static. […]
Hi Eric, Have tested the BT connection , when wifi 7 module is connected. Also, lsusb -t , list BT on usb port8 as below: |__ Port 8: Dev 5, If 0, Class=Wireless, Driver=btusb, 12M |__ Port 8: Dev 5, If 1, Class=Wireless, Driver=btusb, 12M
To understand the static.c generation , i generated build with and without this change(line num 664 to 667). When this change is added, change reflected in static.c is as below: STORAGE struct device _dev_usb2_port8 = { #if !DEVTREE_EARLY .ops = NULL, #endif .bus = &_dev_xhci_root_hub_links[0], .path = {.type=DEVICE_PATH_USB,{.usb={ .port_type = 2, .port_id = 7 }}}, .enabled = 1, -------------> enabled was 0 without the change .hidden = 0, .mandatory = 0, .on_mainboard = 1, .link_list = NULL, .sibling = &_dev_usb2_port9, .probe_list = _dev_usb2_port8_probe_list--> this probelist also got added if !DEVTREE_EARLY .chip_ops = &drivers_usb_acpi_ops, #endif .chip_info = &drivers_usb_acpi_info_9, .next=&_dev_usb2_port9, #if !DEVTREE_EARLY #if CONFIG(GENERATE_SMBIOS_TABLES) #endif #endif where ,below are the other details added: STORAGE struct fw_config _dev_usb2_port8_probe_list[] = { { .field_name = FW_CONFIG_FIELD_WIFI_CATEGORY_NAME, .option_name = FW_CONFIG_FIELD_WIFI_CATEGORY_OPTION_WIFI_7_NAME, .mask = FW_CONFIG_FIELD_WIFI_CATEGORY_MASK, .value = FW_CONFIG_FIELD_WIFI_CATEGORY_OPTION_WIFI_7_VALUE, }, { } };
STORAGE struct drivers_usb_acpi_config drivers_usb_acpi_info_9 = { .desc = "USB2 Bluetooth", .reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D4), .type = UPC_TYPE_INTERNAL, };