Change in coreboot[master]: mainboard/google/puff: Cleanup dt for pci 15.2

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Edward O'Callaghan (Code Review)

15 Dec 2019 15 Dec '19

12:31 p.m.

Hello Edward O'Callaghan,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37736

to review the following change.

Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................

mainboard/google/puff: Cleanup dt for pci 15.2

Seems nothing special is needed here from coreboot.

BRANCH=none BUG=b:143047058 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 1 insertion(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37736/1

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index d5e2e5a..ce5fbc3 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -63,16 +63,7 @@ # RFU - Reserved for Future Use. end # I2C #0 device pci 15.1 off end # I2C #1 - device pci 15.2 on -# chip drivers/i2c/generic -# register "name" = ""PS175"" -# register "desc" = ""PCON PS175"" -# register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" -# register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C11)" -# register "has_power_resource" = "1" -# device i2c 15 on end -# end - end # I2C #2 + device pci 15.2 on end # I2C #2, PCON PS175. device pci 15.3 on # chip drivers/i2c/generic # register "name" = ""RTD21""

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Furquan Shaikh (Code Review)

15 Dec 15 Dec

11:36 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37736 )

Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37736/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37736/1/src/mainboard/google/hatch/... PS1, Line 41: 1 Just noticed this. This should be 2 as per the comment above.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 15 Dec 2019 23:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

11:51 p.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37736 )

Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37736/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37736/1/src/mainboard/google/hatch/... PS1, Line 41: 1

...

Just noticed this. This should be 2 as per the comment above.

ACK, waiting for the boards so i'll fix this once I get them.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 15 Dec 2019 23:51:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

17 Dec 17 Dec

11:56 p.m.

Hello Edward O'Callaghan, Kangheui Won, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37736

to look at the new patch set (#2).

Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................

mainboard/google/puff: Cleanup dt for pci 15.2

Seems nothing special is needed here from coreboot.

V.2: Fix typo as well in speed map.

BRANCH=none BUG=b:143047058 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37736/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

18 Dec 18 Dec

12:12 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37736 )

Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37736/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37736/1/src/mainboard/google/hatch/... PS1, Line 41: 1

...

ACK, waiting for the boards so i'll fix this once I get them.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 18 Dec 2019 00:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan quasisec@google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:25 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37736 )

Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 18 Dec 2019 08:25:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:18 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37736 )

Change subject: mainboard/google/puff: Cleanup dt for pci 15.2 ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37736/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37736/2//COMMIT_MSG@7 PS2, Line 7: Cleanup Clean up

https://review.coreboot.org/c/coreboot/+/37736/2//COMMIT_MSG@11 PS2, Line 11: V.2: Fix typo as well in speed map. Should be a separate commit. Do the schematics list this as 1 instead of 2?

Also, in coreboot we normally do not track the revision for a specific change in the commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 18 Dec 2019 10:18:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

19 Dec 19 Dec

1:42 a.m.

New subject: Change in coreboot[master]: mainboard/google/puff: Clean up dt for pci 15.2

Hello Edward O'Callaghan, Kangheui Won, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37736

to look at the new patch set (#3).

Change subject: mainboard/google/puff: Clean up dt for pci 15.2 ......................................................................

mainboard/google/puff: Clean up dt for pci 15.2

Seems nothing special is needed here from coreboot.

V.2: Fix typo as well in speed map.

BRANCH=none BUG=b:143047058 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37736/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

1:42 a.m.

New subject: Change in coreboot[master]: mainboard/google/puff: Clean up dt for pci 15.2

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37736 )

Change subject: mainboard/google/puff: Clean up dt for pci 15.2 ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37736/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37736/2//COMMIT_MSG@7 PS2, Line 7: Cleanup

...

Clean up

Done

https://review.coreboot.org/c/coreboot/+/37736/2//COMMIT_MSG@11 PS2, Line 11: V.2: Fix typo as well in speed map.

...

Should be a separate commit. Do the schematics list this as 1 instead of 2? […]

No.

Version number stops me messing up Paul.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 19 Dec 2019 01:42:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

20 Dec 20 Dec

6:45 a.m.

New subject: Change in coreboot[master]: mainboard/google/puff: Clean up dt for pci 15.2

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37736 )

Change subject: mainboard/google/puff: Clean up dt for pci 15.2 ......................................................................

mainboard/google/puff: Clean up dt for pci 15.2

Seems nothing special is needed here from coreboot.

V.2: Fix typo as well in speed map.

BRANCH=none BUG=b:143047058 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37736 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 2 insertions(+), 11 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index 384bb9a..ca6c818 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -86,7 +86,7 @@ .rise_time_ns = 0, .fall_time_ns = 0, }, - .i2c[1] = { + .i2c[2] = { .speed = I2C_SPEED_FAST, .rise_time_ns = 0, .fall_time_ns = 0, @@ -111,16 +111,7 @@ # RFU - Reserved for Future Use. end # I2C #0 device pci 15.1 off end # I2C #1 - device pci 15.2 on -# chip drivers/i2c/generic -# register "name" = ""PS175"" -# register "desc" = ""PCON PS175"" -# register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" -# register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C11)" -# register "has_power_resource" = "1" -# device i2c 15 on end -# end - end # I2C #2 + device pci 15.2 on end # I2C #2, PCON PS175. device pci 15.3 on # chip drivers/i2c/generic # register "name" = ""RTD21""

-- To view, visit https://review.coreboot.org/c/coreboot/+/37736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief750f98677b2017af78fb0b5bc98e1492dedbe4 Gerrit-Change-Number: 37736 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1805

days inactive

1810

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Edward O'Callaghan (Code Review)
Furquan Shaikh (Code Review)
Paul Menzel (Code Review)