Attention is currently required from: Bob Moragues, David Wu, Karthik Ramasubramanian, Shelley Chen, Subrata Banik, Tyler Wang, YH Lin.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email )
Change subject: mb/google/brox: Create jubilant variant
......................................................................
Patch Set 17:
(2 comments)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/83212/comment/8d9f4641_4c2e8ba2?usp... :
PS15, Line 85:
add […]
fixed.
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/83212/comment/36c28154_41757b70?usp... :
PS16, Line 86:
: if BOARD_GOOGLE_BROX_COMMON
If this "if" clause is tied to the UFS_AND_NON_UFS line above, it might make sense to join it to the […]
fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83212?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac
Gerrit-Change-Number: 83212
Gerrit-PatchSet: 17
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bob Moragues
moragues@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 30 Jul 2024 02:02:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bob Moragues
moragues@chromium.org