Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58351 )
Change subject: soc/intel/common: add generic gpio lock mechanism
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/58351/comment/4b77423e_282e613f
PS1, Line 348: gpio_lock_pad
Thinking about it, I wonder if we should introduce a new interface function in gpio. […]
How long does the current approach take, hiding & unhiding for every GPIO?
https://review.coreboot.org/c/coreboot/+/58351/comment/669c6045_5d44af9b
PS1, Line 380: #if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)
: /*
: * Lock down GPIOs controllable by a non-host controller
: */
: soc_lock_gpios();
: #endif
#if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS) will conditionally compile the GPIO locking su […]
When you strategically guard things with
`if (CONFIG(blah))`
then you very often don't need weak functions and #if's either
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42979fb89567d8bcd9392da4fb8c4113ef427b14
Gerrit-Change-Number: 58351
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 29 Oct 2021 19:06:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment