Attention is currently required from: Martin Roth, Paul Menzel, Julius Werner, Ron Minnich, HAOUAS Elyes. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50966 )
Change subject: Documentation/coding_style: Issues not mentioned and cleanup patches ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2: Thank you for writing this up! I first thought it might be too much. Sometimes I fear we overengineer rules. But I think it puts it straight enough.
About removing the comment about the GNU coding standards: Seems fair. OTOH, I never followed the advice. Maybe if one did the print&burn, they have a different view on the matter 😄
File Documentation/contributing/coding_style.md:
https://review.coreboot.org/c/coreboot/+/50966/comment/14c34046_f2f3d1c3 PS2, Line 20: changing existing style choices unless they actually violate this style I'm not 100% sure about this wording. Technically, a lot of code violates this style guide wrt. unnecessary braces (for single-statement blocks), for instance. I guess there could be more things things where this document is not up to date wrt. every discussion we had.
Maybe something that avoids to be too picky about single violations:
Bulk style changes to existing code ("cleanup patches") should avoid changing existing style choices unless the surrounding code generally disagrees with this style guide.