build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35680/5/util/pgtblgen/pgtblgen.c
File util/pgtblgen/pgtblgen.c:
https://review.coreboot.org/c/coreboot/+/35680/5/util/pgtblgen/pgtblgen.c@28
PS5, Line 28: printf("usage: %s -b <addr> -a <arch> -o <file>\n", argv[0]);
Prefer using '"%s...", __func__' to using 'usage', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/35680/5/util/pgtblgen/pgtblgen.c@14...
PS5, Line 145: FILE *fd = fopen(filename, "wb");
need consistent spacing around '*' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec92c6cea464c97c18a0811e2e91bc22133ace42
Gerrit-Change-Number: 35680
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Gerd Hoffmann
kraxel@redhat.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 29 Sep 2019 17:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment