Attention is currently required from: Felix Singer, Lance Zhao, Jason Glenesk, Raul Rangel, Nico Huber, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58118 )
Change subject: acpigen,soc/amd/cezanne,intel/{common,skl}: rework CPPC table passing ......................................................................
Patch Set 4:
(14 comments)
File src/soc/amd/cezanne/cppc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/28e70479_abd1352a PS4, Line 15: [CPPC_HIGHEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/42125261_987b15c3 PS4, Line 16: [CPPC_NOMINAL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/5571279d_282dfa48 PS4, Line 17: [CPPC_LOWEST_NONL_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/a3ca50a9_8db53e25 PS4, Line 18: [CPPC_LOWEST_PERF] = CPPC_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/15eaa538_ce9b92f3 PS4, Line 20: [CPPC_DESIRED_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/155ba320_7858039a PS4, Line 21: [CPPC_MIN_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/65af6cdf_5eadf3c3 PS4, Line 22: [CPPC_MAX_PERF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/42210587_4fcca501 PS4, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/c2386666_2727879f PS4, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/c7452d31_3a380c05 PS4, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/cf5a2b1c_9af316fb PS4, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/392ed1ac_517f49c9 PS4, Line 28: [CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/002f00fb_bb799c4a PS4, Line 29: [CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130003): https://review.coreboot.org/c/coreboot/+/58118/comment/e395255f_722a8c8d PS4, Line 34: [CPPC_PERF_PREF] = CPPC_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8), line over 96 characters