Attention is currently required from: YH Lin, Paul Menzel, Tim Wawrzynczak, Zhuohao Lee, Felix Held. Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63544 )
Change subject: mb/google/brask/variants/moli: add delay time to rtd3-cold ......................................................................
Patch Set 6:
(7 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/63544/comment/47fa0ca8_ece3f203 PS1, Line 9: This CL adds the delay time into the RTD3 sequence
Please mention the 50 ms and 20 ms in the commit message for comparison with the code.
Ok, I add 50 ms and 20 ms in the commit message
https://review.coreboot.org/c/coreboot/+/63544/comment/903ebe5b_bfbcc638 PS1, Line 9: This CL adds the delay time into the RTD3 sequence, which will turn : off the eMMC controller (a true D3cold state) during the RTD3 sequence.We checked power on sequence requires enable pin prior to reset pin, added delay to meet the sequence.Base on BH799BB_Preliminary_DS_R079_20201124.pdf in chapter 7.2.
Please reflow for 72 characters per line.
done
https://review.coreboot.org/c/coreboot/+/63544/comment/7b64d90c_9f045b6b PS1, Line 10: .We
Please add a space.
done
https://review.coreboot.org/c/coreboot/+/63544/comment/abb42d73_37b5e10e PS1, Line 9: which will turn : off the eMMC controller (a true D3cold state) during the RTD3 sequence.
So currently the delays are 0, right? Did the device fail to go into D3cold state without any delays […]
The reason is both primus and moli use BH799BB, so I follow this CL: https://review.coreboot.org/c/coreboot/+/62949
https://review.coreboot.org/c/coreboot/+/63544/comment/fa94336c_716e49df PS1, Line 10: .Base
Ditto.
done
https://review.coreboot.org/c/coreboot/+/63544/comment/9f8599d2_611eb635 PS1, Line 10: Base
Based
done
https://review.coreboot.org/c/coreboot/+/63544/comment/a8ded19e_38905a55 PS1, Line 11:
Please mention the 50 ms and 20 ms in the commit message for comparison with the code.
done
-
Raihow Shi (Code Review)