[L] Change in coreboot[main]: [WIP] mb/hardkernel/odroid-h4: add initial odroid-h4 support

[Angel Pons (Code Review)]

Attention is currently required from: Alicja Michalska, David Milosevic.

Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )

Change subject: [WIP] mb/hardkernel/odroid-h4: add initial odroid-h4 support
......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/hardkernel/odroid-h4/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/83979/comment/f78bf613_3fcad56e?usp... :
PS2, Line 82: #device ref pcie_rp3 on
            : 		#	register "pch_pcie_rp[PCH_RP(3)]" = "{
            : 		#		.clk_src = 2,
            : 		#		.clk_req = 2,
            : 		#		.flags = PCIE_RP_CLK_REQ_DETECT,
            : 		#	}"
            : 		#	smbios_slot_desc	"SlotTypeM2Socket3" "SlotLengthOther"
            : 		#				"M.2/M 2280 (M2_SSD1)" "SlotDataBusWidth2X"
            : 		#end
            : 		#device ref pcie_rp7 on	# LAN1
            : 		#	register "pch_pcie_rp[PCH_RP(7)]" = "{
            : 		#		.clk_src = 3,
            : 		#		.clk_req = 3,
            : 		#		.flags = PCIE_RP_CLK_REQ_DETECT,
            : 		#	}"
            : 		#end
            : 		#device ref pcie_rp9 on	# LAN2
            : 		#	register "pch_pcie_rp[PCH_RP(9)]" = "{
            : 		#		.clk_src = 0,
            : 		#		.clk_req = 0,
            : 		#		.flags = PCIE_RP_CLK_REQ_DETECT,
            : 		#	}"
            : 		#end
            : 		#device ref pcie_rp10 on
            : 		#	register "pch_pcie_rp[PCH_RP(10)]" = "{
            : 		#		.clk_src = 1,
            : 		#		.clk_req = 1,
            : 		#		.flags = PCIE_RP_CLK_REQ_DETECT,
            : 		#	}"
            : 		#	smbios_slot_desc	"SlotTypeM2Socket1_SD" "SlotLengthOther"
            : 		#				"M.2/E 2230 (M2_WIFI1)" "SlotDataBusWidth1X"
            : 		#end
> Hi and thanks for your help, Angel :) […]

The only meaningful difference I see is that you've disabled ASPM, which can help if the CLKREQ stuff is misconfigured.

I based my previous comment on the schematics, so it should work as long as the schematics (and my interpretation of them) is correct.