[S] Change in coreboot[master]: soc/amd/picasso: Move AMD firmware from 0x420000 to 0x20000

[Arthur Heymans (Code Review)]

Attention is currently required from: Bao Zheng, Jason Glenesk, Matt DeVillier, Zheng Bao, Martin Roth, Fred Reitberger, Felix Held.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69428 )

Change subject: soc/amd/picasso: Move AMD firmware from 0x420000 to 0x20000
......................................................................

Patch Set 2:

(4 comments)

File src/mainboard/amd/mandolin/Kconfig:

https://review.coreboot.org/c/coreboot/+/69428/comment/61d932f1_d8963241 
PS2, Line 49: config CBFS_SIZE
            : 	default 0x400000 if BOARD_AMD_MANDOLIN # Maximum size for the Mandolin FMAP
            : 	default 0xfcf000 if BOARD_AMD_CEREME # Maximum size for the Cereme FMAP
These options are meaningless since you use an FMAP instead of generate a default one. Just remove everything.

File src/mainboard/amd/mandolin/variants/mandolin/board.fmd:

https://review.coreboot.org/c/coreboot/+/69428/comment/64fc121b_b3f70e8a 
PS2, Line 7: @4M
this should not be needed.

File src/soc/amd/picasso/Kconfig:

https://review.coreboot.org/c/coreboot/+/69428/comment/8bb54bbf_78f4a102 
PS2, Line 400:   The AMDFW (PSP) is typically locatable in cbfs.  Select this
             : 	  option to manually attach the generated amdfw.rom at an
             : 	  offset of 0x20000 from the bottom of the coreboot ROM image.
You are putting the amdfw at the "AMDFW" fmap region. The user needs to create that region at a valid offset. You might want to validate that somehow. e.g. Add a C file that does static asserts on FMAP regions.

File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/69428/comment/7c66bf34_b473f66c 
PS2, Line 291: DD
You're not using DD.