Attention is currently required from: Anil Kumar K, Naveen M.
Subrata Banik has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
Patch Set 7:
(2 comments)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/81920/comment/151c45be_1f676f2d?usp... :
PS7, Line 22: #endif
there should be a else case to handle a scenario where user might have selected DRIVERS_SOUNDWIRE_ALC_BASE_7XX but missed to select between DRIVERS_SOUNDWIRE_ALC722 or DRIVERS_SOUNDWIRE_ALC711.
```
#error "No ALC SoundWire codec selected"
```
https://review.coreboot.org/c/coreboot/+/81920/comment/0d2c4484_debbc00f?usp... :
PS7, Line 162: .name = "Realtek ALC722 SoundWire Codec",
add a else case with "unknown" may be ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 7
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Naveen M
naveen.m@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Naveen M
naveen.m@intel.com
Gerrit-Comment-Date: Wed, 07 Aug 2024 14:24:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No