Attention is currently required from: Jakub Czapiga, Jan Dabros.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57555 )
Change subject: tests: Add lib/lzma-test test case
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File tests/lib/lzma-test.c:
https://review.coreboot.org/c/coreboot/+/57555/comment/6476350d_4bb97b4f
PS8, Line 167: */
Done. […]
Up to you... I think this is certainly fine as it is (and there are other important things to do). If you want to add more, I'd try to focus on testing different LZMA configurations (e.g. different dict size or whatever else you can play with in the filter chain arguments to the lzma util), not just more random files compressed the same way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id75e0b41991382d4c391b031862106de58eacdf7
Gerrit-Change-Number: 57555
Gerrit-PatchSet: 9
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 00:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment