Change in coreboot[master]: soc/intel/common: implement ioc driver - coreboot-gerrit

8 Apr 2022


      Attention is currently required from: Jamie Ryu, Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63198 )
Change subject: soc/intel/common: implement ioc driver
......................................................................
Patch Set 11:
(1 comment)
File src/soc/intel/common/block/ioc/ioc.c:
https://review.coreboot.org/c/coreboot/+/63198/comment/e6bc8214_0e235520 
PS5, Line 9: MCH_BASE_ADDRESS
...
MCHBAR should be enabled very early (in bootblock)
true bt I don't wish to trust FSP, if it clears for some reason. better we just add a check
WDYT ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I768027c2ca78310c03845f70f17df19dc8cd0982
Gerrit-Change-Number: 63198
Gerrit-PatchSet: 11
Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: Ethan Tsao ethan.tsao@intel.com
Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Ethan Tsao ethan.tsao@intel.com
Gerrit-Attention: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 05:46:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment