Attention is currently required from: Paul Menzel, Reka Norman, Ryan Lin, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75679?usp=email )
Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75679/comment/aa4397a5_b9f9d8be :
PS1, Line 10: devicetree.
Fits on the line above.
Acknowledged
https://review.coreboot.org/c/coreboot/+/75679/comment/d0602514_4fcd8a5a :
PS1, Line 11:
Please document the source for these limits.
It shows in PDG.
https://review.coreboot.org/c/coreboot/+/75679/comment/9219b909_a9339b58 :
PS1, Line 13: TEST=emerge-dedede coreboot and read correct value
: on DUT register
Fits into 72 characters.
Acknowledged
https://review.coreboot.org/c/coreboot/+/75679/comment/450eeae1_bc92c678 :
PS1, Line 15:
On what board?
On Dibbi.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75679?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd
Gerrit-Change-Number: 75679
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 08 Jun 2023 08:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment