Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/5231417a_9aa5f903?usp... : PS5, Line 63: fw_config_probe
Jenkins failed because you used >=8 spaces. Please use 2 tabs and <8 spaces.
Done
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/12e19297_79ee534c?usp... : PS5, Line 38: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { : printk(BIOS_DEBUG, "Configure MAX98390 audio\n"); : : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : } else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { : printk(BIOS_DEBUG, "Configure TAS2563 audio\n"); : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : }
Can you check if the FW log shows something like this ? […]
There is relevant printing information, I has been modified.