Attention is currently required from: Nico Huber, Henry Sun, Paul Menzel, Angel Pons, Simon Yang, Kane Chen, Karthik Ramasubramanian.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60301 )
Change subject: mb/google/dedede/var/magolor: Set core display clock to 172.8 MHz
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60301/comment/20b2b377_dd0899e3
PS6, Line 13: recommendation. (refer to src/soc/intel/jasperlake/chip.h)
What frequency is chosen by default? And why is FSP choosing a higher than […]
From CL:60009 's comment:
=> Is this the default config in FSP?
Yes, 0xff is the default value of setting CdClock.
=> Are you planning to upload a follow-up change for Magolor?
No, I will leave it for ODM to adjust it.
The default value in FSP is as before,and keep the CdClock=0xff in baseboard devicetree.
It will not impact all current dedede projects firmware by the change.
For ODM owners, we can overwrite a tuning value in dedede/variant/xxxx devicetree if it's necessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a0ad2bed79b37775184f0bd0a0ef024900cbe34
Gerrit-Change-Number: 60301
Gerrit-PatchSet: 9
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 24 Dec 2021 01:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment