Attention is currently required from: Paul Menzel, Arthur Heymans, Elyes Haouas.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73794 )
Change subject: sb/intel/i82371eb/chip.h: Use 'unsigned int' of 'int' ......................................................................
Patch Set 5:
(1 comment)
File src/southbridge/intel/i82371eb/chip.h:
https://review.coreboot.org/c/coreboot/+/73794/comment/6190c840_8c0cddaa PS3, Line 9: unsigned int ide0_enable:1; : unsigned int ide0_drive0_udma33_enable:1; : unsigned int ide0_drive1_udma33_enable:1; : unsigned int ide1_enable:1; : unsigned int ide1_drive0_udma33_enable:1; : unsigned int ide1_drive1_udma33_enable:1; : unsigned int ide_legacy_enable:1; : unsigned int usb_enable:1; : unsigned int gpo22_enable:1; /* GPO22/GPO23 (1) vs. XDIR#/XOE# (0) */ : unsigned int gpo22:1; : unsigned int gpo23:1;
this way, we change only one file.
I prefer changing multiple files and using bool instead.