Lin Huang has posted comments on this change. ( https://review.coreboot.org/23515 )
Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c File src/soc/rockchip/rk3399/saradc.c:
https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74 PS1, Line 74: udelay(SARADC_DELAY_PU);
Please test multiple combinations (e.g. 4MHz 2 samples, 8MHz 4 samples, etc. […]
Hmm, i do not have the device can repro this issue, i ask manufacturer help to test, and if want to repro this issue, need to put the device into 0C ambient tempterature for 3 or 4 hours, so it may take long time to do the test. Anyway, we will try to do more test.