[M] Change in coreboot[main]: Makefile.mk: Reorganize CFLAGS_common - coreboot-gerrit

15 Jul 2024


      Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83452?usp=email )
Change subject: Makefile.mk: Reorganize CFLAGS_common
......................................................................
Patch Set 4:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83452/comment/9f89ef9c_254437d3?usp... :
PS4, Line 543: CFLAGS_common += -g
...
Maybe move this before the warning options, so that the list continues with them.
In general, it is best to place the -g option at the end of the compilation flags list.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83452?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Gerrit-Change-Number: 83452
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Comment-Date: Mon, 15 Jul 2024 16:04:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de