Attention is currently required from: Derek Huang, Eric Lai, Henry Sun, Paul Menzel, Tarun Tuli.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76104?usp=email )
Change subject: mb/google/nissa: Set up driver as per schematics for gothrax
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76104/comment/f2fb65a3_94ae1f0c :
PS1, Line 7: Setup
The verb is spelled with a space: Set up.
Done
https://review.coreboot.org/c/coreboot/+/76104/comment/ab391686_da1e0619 :
PS1, Line 9: Setup
Ditto: The verb is spelled with a space: Set up.
Done
https://review.coreboot.org/c/coreboot/+/76104/comment/2de6e594_0dd43983 :
PS1, Line 10: and configure the I2C for the TPM.
no need warp. https://www.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/76104/comment/86b16222_0240b543 :
PS1, Line 11:
What source did you use for your changes? Schematics?
Done
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/76104/comment/29d9de8d_7a054723 :
PS1, Line 389: select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER
Why select this?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76104?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1203ca13bd55b8ab96ce5d323a36ffde06860fa9
Gerrit-Change-Number: 76104
Gerrit-PatchSet: 2
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 02:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment