Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 31:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@37 PS30, Line 37: - Everything else works
Dots at the end please.
Done
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@40 PS30, Line 40: - Missing libgfxinit support
Please elaborate what is missing? libgfxinit does not support the device?
Done
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@41 PS30, Line 41: - Missing flashrom support
Also from coreboot? Any idea what is missing?
I removed this, since it's not related to coreboot or to this port. Therefore I think this is a bit misleading here.
flashrom doesn't have support for the platform yet. There is already a patch available, but afaik something is missing, and it needs a rebase. https://review.coreboot.org/c/flashrom/+/37677/
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@42 PS30, Line 42: - Different configuration switches mentioned in ramstage.c
Dot/period at the end.
Done