Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72725 )
Change subject: mb/google/rex: update touchscreen report EN pin setting ......................................................................
mb/google/rex: update touchscreen report EN pin setting
Removed workaround since the latest schematics fixed.
Power Sequencing of ELAN6918 (in ACPI) after this patch `POWER enabled -> RESET deasserted -> Report EN enabled`
BUG=b:247029304 TEST=Verified ELAN touch panel is working as expected after booting Google/rex device to ChromeOS.
Signed-off-by: Ivy Jian ivy.jian@quanta.corp-partner.google.com Change-Id: I19629262776f7e0cccbdebb2285890d177a8a8a6 --- M src/mainboard/google/rex/variants/rex0/gpio.c 1 file changed, 20 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/72725/1
diff --git a/src/mainboard/google/rex/variants/rex0/gpio.c b/src/mainboard/google/rex/variants/rex0/gpio.c index 01fa95d..23732f2 100644 --- a/src/mainboard/google/rex/variants/rex0/gpio.c +++ b/src/mainboard/google/rex/variants/rex0/gpio.c @@ -107,20 +107,7 @@ /* GPP_C05 : [] ==> WWAN_PERST_L_STRAP */ PAD_CFG_GPO(GPP_C05, 1, PLTRST), /* GPP_C06 : [] ==> SOC_TCHSCR_RPT_EN */ - /* - * FIXME: Remove this code after resolving b/247029304. - * - * ELAN6918 Power Sequencing seems not perfectly matching - * with the previous platforms and setting GPP_C06 to high prior - * to the power sequencing is actually makes it work. - * - * Ideally Power Sequencing should be as below for ELAN6918 (in ACPI) - * `POWER enabled -> RESET deasserted -> Report EN enabled` - * - * But below sequence is only working currently: - * `Report EN enabled (ramstage) -> POWER enabled (ACPI) -> RESET deasserted (ACPI)` - */ - PAD_CFG_GPO(GPP_C06, 1, DEEP), + PAD_CFG_GPO(GPP_C06, 0, DEEP), /* GPP_C07 : [] ==> SOC_TCHSCR_INT */ PAD_CFG_GPI_APIC(GPP_C07, NONE, PLTRST, LEVEL, NONE), /* GPP_C08 : [] ==> SOCHOT_ODL */
-
Ivy Jian (Code Review)