Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )
Change subject: soc/intel/tigerlake: Do initial SoC commit ......................................................................
Patch Set 8:
Just to share the thought process behind the copy patch logic and creating newer directory for Intel latest SOC
1. ICL and TGL are different SOC target for different launch year, what does that mean is that, FSP source tree version would be different in both cases so growing TGL inside ICL might be needs to deal with so many #IFDEF/if/#IF logic to guard between ICL and TGL specific changes if we consider UPD alone (which might be ~50% SOC/MB code touch point)
2. We have further analysis and design few coming SOC like JSL inside TGL SOC directory like CNL/WHL/CFL/CML existed due to the fact that JSL and TGL might have same product timeline. trying to making JSL/TGL co-exist inside ICL might looks unnecessarily requirement
3. We are also working on common code 1.1 and 2.0 design which might focus on reducing 8K LOC from soc going forward. we had choice to complete common code 1.1 and 2.0 before landing TGL in that case it might not look 8K LOC for sure but looking at product timeline and effort needs to keep, we have decided to go with copy exist model first and then make TGL specific tree. Eventually with proposed common code effort we will see more thinner soc layer than now.
-
Subrata Banik (Code Review)