Attention is currently required from: Alper Nebi Yasak, Nico Huber.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80368?usp=email )
Change subject: mb/qemu/fw_cfg: Move fw_cfg driver to drivers/emulation/qemu ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Instead of moving things to src/mb/emulation/qemu and src/include, maybe create src/mb/emulation/qemu_common and qemu_common/include and move the files there?
I don't think the qemu header files really belong in src/include.
Obviously you'd need to add qemu_common/include as an include directory in the appropriate makefiles.
File src/drivers/emulation/qemu/Kconfig:
https://review.coreboot.org/c/coreboot/+/80368/comment/919fa754_dfb16141 : PS1, Line 29: bool "QEMU firmware configuration driver"
This shouldn't have a prompt but only be selected by the mainboard ports that need it.
So just use `bool` instead of `bool "prompt"` - that way it won't show up as user configurable.