Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Remove unused variables ......................................................................
Patch Set 15:
(6 comments)
I feel there are some variables that could be removed completely instead of putting assignments to make them seem used.
https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/i... File src/cpu/amd/family_10h-family_15h/init_cpus.c:
https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/i... PS15, Line 1062: !! not needed
https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/pineview/earl... File src/northbridge/intel/pineview/early_init.c:
https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/pineview/earl... PS15, Line 123: u32 reg32; is it me or is reg32 not needed at all?
https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/x4x/early_ini... File src/northbridge/intel/x4x/early_init.c:
https://review.coreboot.org/#/c/29917/15/src/northbridge/intel/x4x/early_ini... PS15, Line 226: reg16 = RCBA16(0x1a8); : reg16 &= ~0x3; : RCBA16(0x1a8) = reg16; What do we need reg16 for?
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage... File src/soc/intel/fsp_baytrail/romstage/romstage.c:
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage... PS15, Line 253: cbmem_was_initted Do we need this variable? I would call cbmem_recovery inside here instead.
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/roms... File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/roms... PS15, Line 119: cbmem_was_initted Same
https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/... File src/southbridge/intel/fsp_rangeley/romstage.c:
https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/... PS15, Line 122: cbmem_was_initted Same
-
Angel Pons (Code Review)