Attention is currently required from: Tim Wawrzynczak, Derek Huang, Brandon Breitenstein, Curtis Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add APIs for USB-C DP ALT mode
......................................................................
Patch Set 13:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57138/comment/85974338_4854a057
PS13, Line 10: and API to wait for DP HPD event
Please add a dot/period at the end.
https://review.coreboot.org/c/coreboot/+/57138/comment/44ccc094_60df5f84
PS13, Line 11:
Please elaborate, why 100 ms delay steps are used.
Please add the output of the new messages from your test board.
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/57138/comment/5c15df6c_8d120740
PS13, Line 1674: mdelay(100);
100 ms sounds excessive for coreboot’s normal execution time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 13
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 01 Oct 2021 05:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment