Change in coreboot[master]: src/lib: Fix a mistake in a comment in imd.c

[Jan Dabros (Code Review)]

Hello Anna Karaś,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/44662

to review the following change.

Change subject: src/lib: Fix a mistake in a comment in imd.c
......................................................................

src/lib: Fix a mistake in a comment in imd.c

Remove the repetition from the comment.

Signed-off-by: Anna Karas 
Change-Id: Ibe6e38636b96b6d8af702b05a822995fd576b2fe
---
M src/lib/imd.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/44662/1

diff --git a/src/lib/imd.c b/src/lib/imd.c
index be4a786..46e985a 100644
--- a/src/lib/imd.c
+++ b/src/lib/imd.c
@@ -466,7 +466,7 @@
    if (imdr_recover(imdr) != 0)
    	return -1;

-	/* Determine if small region is region is present. */
+	/* Determine if small region is present. */
    e = imdr_entry_find(imdr, SMALL_REGION_ID);

if (e == NULL)

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44662 )

Change subject: src/lib: Fix a mistake in a comment in imd.c
......................................................................

Patch Set 1:

The patches look good by themselves, but there are build errors on every platform. You might need to rebase the whole stack and upload new patch sets.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44662 )

Change subject: src/lib: Fix a mistake in a comment in imd.c
......................................................................

Patch Set 2: Code-Review+2

[Jan Dabros (Code Review)]

Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44662 )

Change subject: src/lib: Fix a mistake in a comment in imd.c
......................................................................

Patch Set 3:
> Patch Set 1:
>
> The patches look good by themselves, but there are build errors on every platform. You might need to rebase the whole stack and upload new patch sets.

Hi,

Yes, after the rebase, Jenkins builds are completed successfully.

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44662 )

Change subject: src/lib: Fix a mistake in a comment in imd.c
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44662 )

Change subject: src/lib: Fix a mistake in a comment in imd.c
......................................................................

src/lib: Fix a mistake in a comment in imd.c

Remove the repetition from the comment.

Signed-off-by: Anna Karas 
Change-Id: Ibe6e38636b96b6d8af702b05a822995fd576b2fe
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44662
Reviewed-by: Paul Fagerburg 
Reviewed-by: HAOUAS Elyes 
Tested-by: build bot (Jenkins) 
---
M src/lib/imd.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved

diff --git a/src/lib/imd.c b/src/lib/imd.c
index be4a786..46e985a 100644
--- a/src/lib/imd.c
+++ b/src/lib/imd.c
@@ -466,7 +466,7 @@
    if (imdr_recover(imdr) != 0)
    	return -1;

-	/* Determine if small region is region is present. */
+	/* Determine if small region is present. */
    e = imdr_entry_find(imdr, SMALL_REGION_ID);

if (e == NULL)

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44662 )

Change subject: src/lib: Fix a mistake in a comment in imd.c
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16664
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16663
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16662
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16661
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16660
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16666
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16665

Please note: This test is under development and might not be accurate at all!