Attention is currently required from: Jakub Czapiga, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75578?usp=email )
Change subject: mb/google/rex/variants/ovis: Add USB configuration ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75578/comment/311046ee_99dad761 : PS1, Line 89: device ref tcss_dma0 on : chip drivers/intel/usb4/retimer : register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)" : use tcss_usb3_port1 as dfp[0].typec_port : device generic 0 on end : end : end : device ref tcss_dma1 on : chip drivers/intel/usb4/retimer : register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)" : use tcss_usb3_port2 as dfp[0].typec_port : device generic 0 on end : end : end `tcss_usb3_port3` is missing from here.
``` device ref tcss_dma0 on chip drivers/intel/usb4/retimer register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)" use tcss_usb3_port1 as dfp[0].typec_port device generic 0 on end end chip drivers/intel/usb4/retimer register "dfp[1].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)" use tcss_usb3_port2 as dfp[1].typec_port device generic 0 on end end end device ref tcss_dma1 on chip drivers/intel/usb4/retimer register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)" use tcss_usb3_port3 as dfp[0].typec_port device generic 0 on end end end ```