Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72747 )
Change subject: soc/mediatek: Add support for regulator VM18
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/mt6359p.c:
https://review.coreboot.org/c/coreboot/+/72747/comment/d86c4621_c641c1bf
PS3, Line 329: !!enable
Enable is already a boolean, so the !! is not needed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799
Gerrit-Change-Number: 72747
Gerrit-PatchSet: 4
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 08:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment