Change in ...coreboot[master]: ec/google/wilco: Add ACPI _BIX method for battery

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32093

Change subject: ec/google/wilco: Add ACPI _BIX method for battery
......................................................................

ec/google/wilco: Add ACPI _BIX method for battery

I added a method to fill out the _BIX package structure but never
hooked it up to the expected _BIX method that the OS uses.

This change adds _BIX method and uses the existing method to fill
it out.  It also adds ^ before the _UID in _BIF to match _BIX as
the _UID is one level above the method.

Change-Id: I0de91369b6780fd9432990732c1078a73f6a3419
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/acpi/battery.asl
1 file changed, 13 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/32093/1

diff --git a/src/ec/google/wilco/acpi/battery.asl b/src/ec/google/wilco/acpi/battery.asl
index dd1f69a..e03d3dd 100644
--- a/src/ec/google/wilco/acpi/battery.asl
+++ b/src/ec/google/wilco/acpi/battery.asl
@@ -274,17 +274,22 @@

Method (_STA, 0, Serialized)
    {
-		Return (ESTA (_UID))
+		Return (ESTA (^_UID))
    }

Method (_BST, 0, Serialized)
    {
-		Return (EBST (_UID, PBST))
+		Return (EBST (^_UID, PBST))
    }

Method (_BIF, 0, Serialized)
    {
-		Return (EBIF (_UID, PBIF))
+		Return (EBIF (^_UID, PBIF))
+	}
+
+	Method (_BIX, 0, Serialized)
+	{
+		Return (EBIX (^_UID, PBIX))
    }
 }

@@ -354,4 +359,9 @@
    {
    	Return (EBIF (^_UID, PBIF))
    }
+
+	Method (_BIX, 0, Serialized)
+	{
+		Return (EBIX (^_UID, PBIX))
+	}
 }

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32093 )

Change subject: ec/google/wilco: Add ACPI _BIX method for battery
......................................................................

Patch Set 1: Code-Review+2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32093 )

Change subject: ec/google/wilco: Add ACPI _BIX method for battery
......................................................................

Patch Set 1:

Verify at my side, cycle count can be report correctly.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32093 )

Change subject: ec/google/wilco: Add ACPI _BIX method for battery
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32093/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32093/1//COMMIT_MSG@14 
PS1, Line 14: the _UID is one level above the method.
(which is already done in BAT1).

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32093 )

Change subject: ec/google/wilco: Add ACPI _BIX method for battery
......................................................................

ec/google/wilco: Add ACPI _BIX method for battery

I added a method to fill out the _BIX package structure but never
hooked it up to the expected _BIX method that the OS uses.

This change adds _BIX method and uses the existing method to fill
it out.  It also adds ^ before the _UID in _BIF to match _BIX as
the _UID is one level above the method.

Change-Id: I0de91369b6780fd9432990732c1078a73f6a3419
Signed-off-by: Duncan Laurie 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32093
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Paul Menzel 
---
M src/ec/google/wilco/acpi/battery.asl
1 file changed, 13 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/ec/google/wilco/acpi/battery.asl b/src/ec/google/wilco/acpi/battery.asl
index dd1f69a..e03d3dd 100644
--- a/src/ec/google/wilco/acpi/battery.asl
+++ b/src/ec/google/wilco/acpi/battery.asl
@@ -274,17 +274,22 @@

Method (_STA, 0, Serialized)
    {
-		Return (ESTA (_UID))
+		Return (ESTA (^_UID))
    }

Method (_BST, 0, Serialized)
    {
-		Return (EBST (_UID, PBST))
+		Return (EBST (^_UID, PBST))
    }

Method (_BIF, 0, Serialized)
    {
-		Return (EBIF (_UID, PBIF))
+		Return (EBIF (^_UID, PBIF))
+	}
+
+	Method (_BIX, 0, Serialized)
+	{
+		Return (EBIX (^_UID, PBIX))
    }
 }

@@ -354,4 +359,9 @@
    {
    	Return (EBIF (^_UID, PBIF))
    }
+
+	Method (_BIX, 0, Serialized)
+	{
+		Return (EBIX (^_UID, PBIX))
+	}
 }