4 Sep
2019
4 Sep
'19
8:33 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33391 )
Change subject: mediatek/mt8183: Allow modifying vcore voltage ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33391/1/src/soc/mediatek/mt8183/mt6... File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/c/coreboot/+/33391/1/src/soc/mediatek/mt8183/mt6... PS1, Line 771: 500000
I would prefer having some constants for these values (e.g., 500000, 1100000). […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/33391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic43d5efe7e597121775dc853a3e2a08ebc59657d
Gerrit-Change-Number: 33391
Gerrit-PatchSet: 11
Gerrit-Owner: hsin-hsiung wang hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Huayang Duan huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Sep 2019 08:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: You-Cheng Syu youcheng@google.com
Gerrit-MessageType: comment