Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52545 )
Change subject: src/soc/amd/picasso: Add HDMI 2.0 disable setting for project custom design
......................................................................
Patch Set 4:
(2 comments)
File src/soc/amd/picasso/chip.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117560):
https://review.coreboot.org/c/coreboot/+/52545/comment/b0f51237_f7ea6072
PS4, Line 178: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117560):
https://review.coreboot.org/c/coreboot/+/52545/comment/940c3e31_3720152d
PS4, Line 180: * bit0~3: disable HDMI 2.0 DDI0~3
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I383bfd04e01f5202db093105662344869e475746
Gerrit-Change-Number: 52545
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 22 Apr 2021 08:54:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment