Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42572 )
Change subject: arch/x86: always add mptable.c if GENERATE_MP_TABLE is selected
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42572/2/src/arch/x86/Makefile.inc
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42572/2/src/arch/x86/Makefile.inc@2...
PS2, Line 284: ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/mptable.c
How about having boards specify where the mptable. […]
that's probably the way to go there and would allow to fix the 2 variants of that one asus board. might look into that on the weekend
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42572
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d19a6db09881989d7b1e0249f44eb7e9c3f1df6
Gerrit-Change-Number: 42572
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 21:19:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment