25 Apr
2019
25 Apr
'19
3:53 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32436 )
Change subject: mb/google/sarien: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32436/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32436/2//COMMIT_MSG@11 PS2, Line 11: update when running on battery. I'm a bit confused about this commit message. It states why it is desirable to turn it off, but not why it isn't required any more. So was it enabled by accident before?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32436
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b687285eb95070eaffb68611a7d98eb8434ce2c
Gerrit-Change-Number: 32436
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Short keithshort@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Keith Short keithshort@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Thu, 25 Apr 2019 13:53:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment