Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30849 )
Change subject: mb/emulation/qemu-i440fx: use car for e820 ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/30849/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/30849/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 20: #include <arch/early_variables.h> not needed
https://review.coreboot.org/#/c/30849/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 29: static int fw_cfg_detected CAR_GLOBAL; no need for CAR_GLOBAL. To make it compile in romstage remove "= 0xff"
https://review.coreboot.org/#/c/30849/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 37: if (car_get_var(fw_cfg_detected) == 0) { no need for car_get_var or car_set_var