Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31724 )
Change subject: mb/google/hatch: Initialize all gpios ......................................................................
Patch Set 2:
(34 comments)
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 31: /* A7 : PP3300_SOC_A */ : PAD_CFG_GPI(GPP_A7, NONE, PLTRST), This is just PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 37: PAD_CFG_GPO(GPP_A10, 0, DEEP), This should be PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 48: DN_20K I think we should get rid of this.
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 65: FPMCU_PCH_INT_ODL Not for this change, but if this is being treated as a wake source, we will have to enable that on the same line.
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 97: GPP_B14 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 115: GPP_B23 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 130: GPP_C6 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 132: GPP_C7 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 202: GPP_D12 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 203: /* D13 : ISH_UART_RX */ : PAD_CFG_NF(GPP_D13, NONE, DEEP, NF1), : /* D14 : ISH_UART_TX */ : PAD_CFG_NF(GPP_D14, NONE, DEEP, NF1), PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 210: TOUCHSCREEN_INT_L Net name needs to be updated.
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 211: TODO Configure it back to invert mode, when : * ITSS IPCx configuration is fixed in FSP. This is actually not true.
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 216: GPP_D17 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 218: GPP_D18 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 220: PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 222: GPP_D20 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 247: GPP_E6 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 256: * space before *
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 258: * same here
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 265: DN_20K NONE
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 267: DN_20K NONE
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 271: DN_20K NONE
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 273: GPP_E19 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 275: DN_20K NONE
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 277: GPP_E21 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 279: DN_20K NONE
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 281: GPP_E23 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 288: DN_20K Not required
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 362: GPP_H4 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 364: GPP_H5 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 396: GPP_H21 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 400: GPP_H23 PAD_NC
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 402: GPD2 We should check if other GPDs need to be configured too.
https://review.coreboot.org/#/c/31724/2/src/mainboard/google/hatch/variants/... PS2, Line 436: DN_20K NONE. Why is this configured early and not the rest of MEM config GPIOs?