Attention is currently required from: Haribalaraman Ramasubramanian, Rizwan Qureshi, Reka Norman, Kapil Porwal, Sridhar Siricilla.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details ......................................................................
Patch Set 19:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74005/comment/8a3ce8dd_17e65f4a PS1, Line 10: version details of ISHC.
Can you indicate the purpose to retreive the version details of ISHC?
The query was about an older description. The description has since been updated to reflect the changes in implementation. The current implementation of the API retrieves partition information, and it is not specific to ISHC. In subsequent changes, the API will be used to retrieve ISHC version.
I understand your suggestion to include the purpose of ISHC retrieval in the description. I will include that information in the pertinent subsequent changelist.
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74005/comment/de9acb61_c24a4cc7 PS18, Line 1226: .group_id = MKHI_GROUP_ID_GEN, : .command = MKHI_BUP_COMMON_GET_BOOT_PARTITION_INFO,
Thanks Subrata for adding me to the bug. […]
Acknowledged! The command id is updated to `GEN_GET_IMAGE_FW_VERSION` to be aligned with bug.
https://review.coreboot.org/c/coreboot/+/74005/comment/aee9d8cb_2d0494e5 PS18, Line 1231:
Please add check for prerequisites. […]
The command id itself is updated to `GEN_GET_IMAGE_FW_VERSION` to be aligned with bug.