Attention is currently required from: Nico Huber, Kyösti Mälkki. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52934 )
Change subject: nb/amd/agesa/family14/: Use generic allocation functions for northbridge ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52934/comment/a4b683ce_bc211d86 PS2, Line 9: Remove obsolete resource assigning functions.
Why are they obsolete?
Elaborated a bit in the commit message attempting to explain it.
Patchset:
PS2:
Unless I missed something, this is a mess. The commit message is almost empty. Why can the code be dropped? and if we can drop the assignments, why do we allocate the resources in the first place?
The generic functions do the resource assignments. Why it can be dropped is explained in the commit message right now.
It would probably be a good idea to separate NB and domain code changes into individual commits. And also not to mix cosmetical changes in.
Split it per your suggestion. Let me know what I can do more to make the review easier for you. I don't see any cosmetical changes right now.
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52934/comment/059593c7_fb8009fa PS2, Line 448: set_resource(dev, res, nodeid);
If we can drop this, why does the respective code in nb_read_resources() stay?
Right, the respective code in nb_read_resources does not do anything meaningful too. Removed.