Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33956 )
Change subject: drivers/amd/agesa: Drop redundant stack allocation
......................................................................
Patch Set 2: Code-Review+1
AGESA resume from S3 still works with G505S with this. Although - if combined with a new "CONFIG_SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT" - S3 stops working (haven't tested this config alone yet).
Always clear the DRAM after DRAM initialization regardless of additional security implementations in use.
This increases boot time depending on the amount of DRAM installed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03a44bc3252f553b1769d362b2f442d3e6ab73f4
Gerrit-Change-Number: 33956
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 12:31:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment