Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )
Change subject: Choose Correct FW splash screen at runtime ......................................................................
Patch Set 7: Code-Review+1
(5 comments)
File src/include/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/79775/comment/65936c9f_6162a376 : PS7, Line 19: const char *get_bmp_file(void); nit: some help text is required to let user know that any user can override this implementation if they have HAVE_CUSTOM_BMP_LOGO config enabled. for example: chromeos devices can override
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79775/comment/88488c98_55fb6539 : PS7, Line 156: ramstage-$(CONFIG_CHROMEOS_FW_SPLASH_SCREEN) += bmp_logo.c do we really need this?
CONFIG_CHROMEOS_FW_SPLASH_SCREEN will anyway select CONFIG_BMP_LOGO ? hence, line 155 should be enough ?
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/79775/comment/5f9c36df_eace31f4 : PS7, Line 88: Display the ChromeOS splash screen in the firmware. nit: Choose this option to let boot firmware to render the OEM splash screen. As an usecase point of view, ChromeOS devices are opting for this config to render the OEM splash screen early during boot for an improved user experience.
https://review.coreboot.org/c/coreboot/+/79775/comment/aa6734b7_ebe77ffd : PS7, Line 91: CB nit: should we say "Chromebook" or "ChromeOS" ?
https://review.coreboot.org/c/coreboot/+/79775/comment/35b948e7_bff1717f : PS7, Line 96: CB nit: Chromebook ?