Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/23711 )
Change subject: security/tpm: Add SW hash functions for measurements ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/23711/4/src/security/crypto/Makefile.inc File src/security/crypto/Makefile.inc:
https://review.coreboot.org/#/c/23711/4/src/security/crypto/Makefile.inc@a21 PS4, Line 21: why do you remove smm hash support ?
https://review.coreboot.org/#/c/23711/4/src/security/tpm/Kconfig File src/security/tpm/Kconfig:
https://review.coreboot.org/#/c/23711/4/src/security/tpm/Kconfig@93 PS4, Line 93: Enables hardware accerlated hashes. A TPM HW feature. accelerated hashing
https://review.coreboot.org/#/c/23711/4/src/security/tpm/tspi/tspi.c File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/#/c/23711/4/src/security/tpm/tspi/tspi.c@196 PS4, Line 196: #if IS_ENABLED(CONFIG_TPM_HW_HASHES) please use if(IS_ENABLED(CONFIG_TPM_HW_HASHES))