Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34559 )
Change subject: mb/google/hatch: Fine-tune Kohaku I2C CLK frequency
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34559/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34559/1//COMMIT_MSG@9
PS1, Line 9: Add rise time / fall time to I2C config in device tree
Where did you get the timings from?
https://review.coreboot.org/c/coreboot/+/34559/1//COMMIT_MSG@10
PS1, Line 10: to ensure I2C CLK runs accurately at I2C_SPEED_FAST (400 kHz).
Please use the full text width.
https://review.coreboot.org/c/coreboot/+/34559/1//COMMIT_MSG@15
PS1, Line 15: verify all of them run at 395-399 kHz.
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id98079e717f0db3fdcb88f85e45693925d11d7fd
Gerrit-Change-Number: 34559
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 13:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment