Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46505 )
Change subject: soc/amd/picasso: Fix typo in SMU argument base ......................................................................
soc/amd/picasso: Fix typo in SMU argument base
Correct the base address. This should have no noticeable effect, as SMC_MSG_S3ENTRY accepts no arguments and doesn't return. The argument writes were not getting to any target.
BUG=b:171037051 TEST=Run SST on morphius
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: Ie3402f743cf7d4f4f42b8afa3e8b253be4761949 --- M src/soc/amd/picasso/include/soc/smu.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/46505/1
diff --git a/src/soc/amd/picasso/include/soc/smu.h b/src/soc/amd/picasso/include/soc/smu.h index 128f4c4..eb7573c 100644 --- a/src/soc/amd/picasso/include/soc/smu.h +++ b/src/soc/amd/picasso/include/soc/smu.h @@ -11,7 +11,7 @@
#define REG_ADDR_MESG_ID 0x3b10528 #define REG_ADDR_MESG_RESP 0x3b10564 -#define REG_ADDR_MESG_ARGS_BASE 0x0b10998 +#define REG_ADDR_MESG_ARGS_BASE 0x3b10998
/* Argument 0-5 indexed locations are contiguous */ #define SMU_NUM_ARGS 6