Dhaval Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29775 )
Change subject: SMI: Introduce CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c File src/ec/google/chromeec/smihandler.c:
https://review.coreboot.org/#/c/29775/1/src/ec/google/chromeec/smihandler.c@... PS1, Line 102: #if IS_ENABLED(CONFIG_SOC_INTEL_BYPASS_PORT_B2_SMI)
Okay.. […]
You will still have to populate 0 to SMI PORT in FADT to ensure OS doesn't expose that port. wrt naming I think what you have should work (one config per feature). That way one can easily select/de-select specific SMI feature. But may be we should use a naming convention like NO_SMI or something like that so that we know that the implementation belongs to same family/purpose which is to reduce SMI usage on platform.