Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35612 )
Change subject: mb/google/kukui: Extend FMAP to 8MB layout
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35612/1/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/35612/1/src/mainboard/google/kukui/...
PS1, Line 28: RW_UNUSED
Why waste so much? If you have space left over I'd suggest to distribute it among the FW_MAIN sections and RW_LEGACY. (There's no particular reason to align anything other than the FMAP by anything more than 4K that I'm aware of.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id342d57dc95c6197d05b8a265742a2866c35ae09
Gerrit-Change-Number: 35612
Gerrit-PatchSet: 1
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Ho
Ben.Ho@mediatek.com
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-CC: You-Cheng Syu
youcheng@google.com
Gerrit-Comment-Date: Thu, 26 Sep 2019 05:42:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment